2 ms·
I respectfully disagree. I worked with "trunk"s before, won't do that again, sorry. I would argue that Pull Requests (or Merge Requests) are the single most ef
by alentred 3y ago
I respectfully disagree. I worked with "trunk"s before, won't do that again, sorry.
I would argue that Pull Requests (or Merge Requests) are the single most efficient practice to ensure the quality of the code in a project with many people, right after the CI with linters, formatters, tests, etc. which you should set up even if you work alone (at least running them locally). Not to mention the knowledge sharing aspect of PR/MR reviews. It is a very versatile practice where a reviewer (or several reviewers!) can review the code itself from a different perspective and in a different setting, review the design (or "architecture", if you want), learn something new themselves, and keep up to date with the changes in the source code, but also in a product in general. Even in my solo projects I always take five before committing the code, in order to review it first with a clear head.