3 ms·
It depends on your knowledge level, I wouldn't be loud about mistakes that are part of your learning experience, especially on your local, and about things you
by saluki 3y ago
It depends on your knowledge level, I wouldn't be loud about mistakes that are part of your learning experience, especially on your local, and about things you might not fully understand. This could be more problematic.
If you find a mistake that is committed to the repo, own it, make a PR to fix it and document it in the PR, if it's knowledge that can help other add to wiki.
Same if someone else points out a mistake or recommended change. Explore the issue, research it, understand it fully so it doesn't happen again. Fix it, setup PR.
If it's not in the repo yet make the fix as part of your PR for that feature but I wouldn't air my dirty laundry. Adding something to the wiki or documentation to help others would be a good idea but you don't have to spell it out as a mistake.