4 ms·
Check out the following issue, not just the matter of style.. https://github.com/twitter/bootstrap/issues/401 https://github.com/twitter/bootstrap/issues/401
by tszming 15y ago
Check out the following issue, not just the matter of style..
https://github.com/twitter/bootstrap/issues/401 https://github.com/twitter/bootstrap/issues/401
- matt_yoho 15y agoThe reply seems immature from the perspective of project maintenance.
- brown9-2 15y agoAgreed. Aesthetics should be the first thing to go when they cause real-life issues for what you are making. The only value of the aesthetics of not having semi-colons is to the developer himself.
- glenngillen 15y agoThat seemed to be a trend in this project, that we briefly overcame: https://github.com/twitter/bootstrap/pull/266 https://github.com/twitter/bootstrap/pull/266
- jed_s 15y ago> many providers (o2, t-mobile, vodafone) across the world embed another js script > The lack of semi-colons in the dropdown js file causes this compression to break Thanks for the heads up, no bootstrap for me! (At least without something that's going to add the necessary semicolons... I wonder how many HN weekend projects out there simply don't work for people using their wireless connections?) Also interesting that it appears the issue was closed because it contained the key phrases 'compression' and 'semicolon'... but it was not re-opened even after the maintainer realized the problem is with the wireless providers.
- ricardobeat 15y agoEven when using semi-colons freely, most people don't put a guarding ; at the beggining or end of the file. That's unrelated to this coding style. And honestly, that should be done by the minifier. It breaks perfectly valid javascript.