2 ms·
Reddit died for a number of hours because of this, too. https://www.reddit.com/r/RedditEng/comments/11xx5o0/you_broke_reddit_the_piday_outage/ https://www.redd
by bombcar 4y ago
Reddit died for a number of hours because of this, too.
https://www.reddit.com/r/RedditEng/comments/11xx5o0/you_broke_reddit_the_piday_outage/ https://www.reddit.com/r/RedditEng/comments/11xx5o0/you_brok...
> The nodeSelector and peerSelector for the route reflectors target the label `node-role.kubernetes.io/master`. In the 1.20 series, Kubernetes changed its terminology from “master” to “control-plane.” And in 1.24, they removed references to “master,” even from running clusters. This is the cause of our outage. Kubernetes node labels.
- freedomben 4y agoYep, this has been a constant pain point for me nearly every day. Having dozens of repos I work in across multiple organizations, where half follow the old convention (master) and the other half follow new (main), when I want to switch branches I usually have to do it twice. First `git co main` and if that doesn't work, `git co master`. Vice versa doesn't work because older repos that have been converted have a master branch! It's usually way behind. There are also tons of scripts and CI/CD yaml everywhere that has to be modified for main vs. master. Main is a better name IMHO (increased clarity and brevity) but it is far from "zero downside."
- bombcar 4y agoIt should have been built into the client so that if a co of main fails, it tries master. But that would be too easy.