4 ms·
As someone who works in (and leads) the development of a 100k LOC project with four developers (project lead, tech lead and two junior developers) I see pull re
by Zobat 3y ago
As someone who works in (and leads) the development of a 100k LOC project with four developers (project lead, tech lead and two junior developers) I see pull requests as a way for other members (often me or tech lead) to 1) spot clunky code 2) spot things that already exist in the code and should be unified 3) a way to teach and be taught about how we want the code to work.
I know that "my" team members look at PRs as more of a safety net for oopsies than evidence of lack of trust between team members. We allow self approval of PRs so that if/when someone is the only developer working they can still push code if needed.
When I started in the project we did not use PRs and we all agree that they have made the code better and that they have unified our coding style (the fact that Visual Studio/ReSharper auto-formats changed code also helps with that aspect).