4 ms·

I've had groups where I eventually 'approved' a PR, because... deadlines... even when it wasn't meeting defined standards (primarily around tests/docs). Commen

I've had groups where I eventually 'approved' a PR, because... deadlines... even when it wasn't meeting defined standards (primarily around tests/docs). Comments like "please add a test" or "please document X" were just ignored (both inside the version control system and in slack). Eventually, I would merge, and occasionally, we'd hit some bug, trace it back to that, and I would catch blame for "passing" it. Not the person who wrote it, not the same person who didn't test it or add any automated tests. I did, even though I was doing so under protest. The couple times I added to their PR - added a test to verify behaviour, for example - I got called out for "stepping on others' code". Apparently if you went out on smoke breaks with 'the guys', they were 'cool' wit h you and that was the political way of getting people 'on your side' to go along with stuff. Very ... odd dynamics. Apparently, if you're dating the dept head's niece, writing tests was optional, but I never got that memo.

recursive 3y ago
Simple solution to that is don't pass it. When the deadline comes, you'll have the reason documented.
dkersten 3y ago
That sounds like a team problem. In my team, contents get addressed and team members don’t approve PR’s they don’t feel meet standards even if there are deadlines.
- lowercased 3y ago
  Glad things get addressed for you. In some places I've worked, they don't. They carry on like my post above. I did have a 6 month contract with a fairly tight team back in 2019, and it was definitely overall a positive experience. Mix of experience levels, and they were growing perhaps a bit too fast, but there was enough balance and communication. Most people were on site, which did, I think, help out some. I know "remote only 100%" is everyone's favorite 'go to' mode (mine too) but there's some extra discipline and rigor the whole org needs to have to function smoothly to get the best out of a mostly or fully remote workforce.
idontreadtheop 3y ago
[flagged]

recursive 3y ago

Simple solution to that is don't pass it. When the deadline comes, you'll have the reason documented.

dkersten 3y ago

That sounds like a team problem. In my team, contents get addressed and team members don’t approve PR’s they don’t feel meet standards even if there are deadlines.

lowercased 3y ago
Glad things get addressed for you. In some places I've worked, they don't. They carry on like my post above. I did have a 6 month contract with a fairly tight team back in 2019, and it was definitely overall a positive experience. Mix of experience levels, and they were growing perhaps a bit too fast, but there was enough balance and communication. Most people were on site, which did, I think, help out some. I know "remote only 100%" is everyone's favorite 'go to' mode (mine too) but there's some extra discipline and rigor the whole org needs to have to function smoothly to get the best out of a mostly or fully remote workforce.

idontreadtheop 3y ago

[flagged]