19 ms·

Calling pull requests "pull request" when it is a job to create a change is what's wrong. The author isn't actually requesting anything. But what else could be

• HPsquared 3y ago
  Change proposal
• alpaca128 3y ago
  Review submission?
• giantrobot 3y ago
  It's a "pull request" because you're asking someone to pull a commit from your branch/repo into theirs. You're quite literally making a request. This actual change could be anything. You could just as well provide them as a patch they could apply by hand. The only formal aspects of the process, e.g. reviews and tests, are organizational. As an organization the acceptance of a pull request doesn't need a bunch of reviews and tests associated.
• ilyt 3y ago
  The problem is again, Github Originally, "pull request" was exactly what name implied, someone asked you to pull from their repository. The original Git collaboration model was that, you pulling changes from other repos and integrating them in your own, vs handing merge request. Github co-opted the term to mean exact opposite, accepting essentially push from different repo.
• javier_e06 3y ago
  I couldn't agree more. When the PR is approved then the button to complete the PR in Github is (drum-roll please) MERGE. And who is doing the merge? Me. Gitlab calls it merge request.