3 ms·
> I don't want a tool to blindly stomp any of these when it lacks understanding how they benefit readers Some dev will have 1 newline after a method ends, anot
by sumedh 4y ago
> I don't want a tool to blindly stomp any of these when it lacks understanding how they benefit readers
Some dev will have 1 newline after a method ends, another dev will have two newlines, some might have 3 etc. Should you as a code reviewer be wasting time looking for such issues and putting comments tell the other to fix such issues?
- erik_seaberg 4y agoIt’s not my job to make you write exactly what I would have. I don’t care about an extra blank line, and I expect a reviewer to accept that it doesn’t matter. I draw the line at layout that is misleading about the code (e.g., dangling else that doesn’t parse the way it’s indented).
- sumedh 4y ago> I don’t care about an extra blank line..I expect a reviewer to accept that it doesn’t matter. You dont care about an extra blank line, what about 2 extra lines, what about three and so on. Do you see why there is a need for a consistent style?
- erik_seaberg 4y agoIf it gets to a dozen I’d grumble about wanting to fit more code on screen, but this just isn’t a problem we’ve ever had. I think the urge to enforce complete uniformity is bad for a collegial high-trust team.
- sumedh 4y ago> If it gets to a dozen I’d grumble about wanting to fit more code on screen exactly, which is why such rules should be part of the code, no need to trust if such conventions are followed if the rule will take care of it. You should spend your time doing some meaningful not wasting it on such issues.
- deleted 4y ago[deleted]