3 ms·
Random observation from reading the source: your tweak is going to cause issues (possibly crashes) if the application is accessing the address book on a non-mai
by eridius 15y ago
Random observation from reading the source: your tweak is going to cause issues (possibly crashes) if the application is accessing the address book on a non-main thread. You should dispatch_async() that alert over to the main thread.
- bri3d 15y agoIt actually just causes CoreAnimation fence issues and messy animations as far as I can tell, but you're entirely right. Fixing in my next commit (which also fixes some other brokenness). Even had a note in the TODO about it. This is the first time I've used MobileSubstrate and Logos, so I'm having a lot of fun :) update: fixed.
- conradev 15y agoSince you seem to be enjoying the experience, feel free to join #theos on irc.saurik.com, it's all we discuss!
- eridius 15y agoYou may only be seeing CoreAnimation fencing issues, but the fact is, you're accessing main-thread-only classes from a background thread, and it has the potential to corrupt data structures which can lead to crashes and other bad behavior. Glad to see you fixed it though.