3 ms·
Gb has F#° as the diminished. I'll also note you stick to natural/# for diminished. For minor, you transition between #/b boundary at D#m/Bbm but for major yo
by ksherlock 4y ago
Gb has F#° as the diminished.
I'll also note you stick to natural/# for diminished. For minor, you transition between #/b boundary at D#m/Bbm but for major you transition at the B/Gb boundary. Personally I'd go with F# and be consistent between major and minor.
- epiccoleman 4y agoAh yeah, dammit. I've already fixed the Gb diminished chord in the current source, but I was taking screenshots from old commits. I will definitely fix the transition with minor/major though, that's awkward. Thanks for the feedback! I may eventually switch over to Tonal for the key data, right now it's just hardcoded. Edit: just published v0.1.3, which fixes this issue. Long term, might be nice to display both sharp and flat on that key, but at least it's consistent for now. Thanks again!