5 ms·

Roughly 7 years ago, I started using strict equality comparisons (===) in PHP and JS to avoid issues like this, and doing so has had zero negative impact on my

Roughly 7 years ago, I started using strict equality comparisons (===) in PHP and JS to avoid issues like this, and doing so has had zero negative impact on my code and obviously a MUCH higher upside. Is there any reason for using sameness (==) merely beyond convenience?

hombre_fatal 3y ago
I can't even remember the last time I worked in a Javascript project where you could find "==" in the codebase. It even got phased out as a convenient "null or undefined" check. Between it being an ancient footgun and the ubiquity of linters, making fun of "==" code ends up just making fun of beginners.
- isleyaardvark 3y ago
  Thank goodness for nullish coalescing.
- eyelidlessness 3y ago
  I still use it for null/undefined checks, because it’s almost always what’s intended/expected. I was surprised to find out recently that this is even a remotely controversial take. I do try to use the newer language features like nullish-coalescing and optional chaining to make the check less necessary, but sometimes it makes more sense (clearer code, less unnecessary code execution) to check for null/undefined and return early.
  - hombre_fatal 3y ago
    Even with a linter that can approve of that one use case, the problem with == these days is that it catches everyone off guard, and every developer who sees the code has to do the same "did they mean to use this or-- oh, it's for a null|undefined check" every single time. Just because of that I've created an `isNil = (x) => x is undefined or null` function and banished == from my code. == can lead to what we've jokingly called tollbooth code: code that can make every reader stop and pay a mental toll while they confirm that the writer did intend to write the code that way.
    - eyelidlessness 3y ago
      This is surprising to me! I/my team do use such a linter rule (non-strict equals errors for all cases except directly comparing to null), and I don’t even notice it while reading code because the linter is satisfied, and because it reads as (obviously, to me) correct. It never occurred to me that it could be so noticeable to others as to add any cognitive overhead. I’m not discounting that at all, to be clear, only that it’s not something I’d ever considered before now.
      - fuckingbonkers 3y ago
        We have banished it as well for this exact reason — the “toll” — if you want 1 more piece of anecdata.

hombre_fatal 3y ago

I can't even remember the last time I worked in a Javascript project where you could find "==" in the codebase. It even got phased out as a convenient "null or undefined" check. Between it being an ancient footgun and the ubiquity of linters, making fun of "==" code ends up just making fun of beginners.

isleyaardvark 3y ago
Thank goodness for nullish coalescing.
eyelidlessness 3y ago
I still use it for null/undefined checks, because it’s almost always what’s intended/expected. I was surprised to find out recently that this is even a remotely controversial take. I do try to use the newer language features like nullish-coalescing and optional chaining to make the check less necessary, but sometimes it makes more sense (clearer code, less unnecessary code execution) to check for null/undefined and return early.
- hombre_fatal 3y ago
  Even with a linter that can approve of that one use case, the problem with == these days is that it catches everyone off guard, and every developer who sees the code has to do the same "did they mean to use this or-- oh, it's for a null|undefined check" every single time. Just because of that I've created an `isNil = (x) => x is undefined or null` function and banished == from my code. == can lead to what we've jokingly called tollbooth code: code that can make every reader stop and pay a mental toll while they confirm that the writer did intend to write the code that way.
  - eyelidlessness 3y ago
    This is surprising to me! I/my team do use such a linter rule (non-strict equals errors for all cases except directly comparing to null), and I don’t even notice it while reading code because the linter is satisfied, and because it reads as (obviously, to me) correct. It never occurred to me that it could be so noticeable to others as to add any cognitive overhead. I’m not discounting that at all, to be clear, only that it’s not something I’d ever considered before now.
    - fuckingbonkers 3y ago
      We have banished it as well for this exact reason — the “toll” — if you want 1 more piece of anecdata.