4 ms·
There's a balance here, and for me it comes down to whether or not I'll be able to remember all of the narrow edge cases that this particular piece of code will
by the_sleaze9 4y ago
There's a balance here, and for me it comes down to whether or not I'll be able to remember all of the narrow edge cases that this particular piece of code will introduce.
Will braces around if statements matter when QA comes back with a regression 4 weeks from now or when Product has a new feature request? Probably not, so a "LGTM with a nit" is warranted.
Adding a json request body to this GET request? Yeah, I'll have to remember that little bit of quirkiness, and quite frankly if the team member is adding bodies to GETs, I can't rely on them to remember that quirk or solve anything after that. So while that is technically a "style choice" since it does work, that's a blocked PR until Requested Changes are made.