3 ms·
Yeah, I said I just read through it at random. I know that some programmers hate getting their code reviewed. All I can say is that code reviews are, in my exp
by t8sr 4y ago
Yeah, I said I just read through it at random.
I know that some programmers hate getting their code reviewed. All I can say is that code reviews are, in my experience, strongly correlated with code that's cheaper to maintain and operationally less surprising.
Seeing this code certainly makes me think that the team writing it either doesn't have a culture of taking code reviews seriously, or that they don't have a lot of people who know the best practices in this language (Go). Either way, if they're not catching the easy stuff, I don't trust them to catch the subtle stuff either.