4 ms·

Bugs in your code are bugs in your code. If they are user-facing, you could've had tests to catch them.

by whateveracct 4y ago

sharemywin 4y ago
this.
curiousgal 4y ago
But it's an open-source library... /s
- moffkalast 4y ago
  Maybe they should be reminded that redis-py is under the MIT license. > THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
nawgz 4y ago
"Why didn't you simply have a test for an unexpected failure case which arose as a result of moving pieces across a distributed system?" - whateveracct
- aldarisbm 4y ago
  you’re retrieving data from a cache, is it so outrageous to say that they should confirm that the data belongs to the account is retrieving it?
  - Atheros 4y ago
    It is pretty outrageous, yes. If Alice logs in and I correctly request Alice's details from the database, it's reasonable for me to expect that the database either returns Alice's details or an error. It shouldn't be up to application-layer programmers to code checks to make sure that a database doesn't return the wrong data 1% of the time. That kind of test is a test for the developers of Asyncio and Redis to implement, not users of Asyncio and Redis.
- whateveracct 4y ago
  I mean I have tested such things many times over the years. I'm no stranger to Redis cache bugs. Being a professional means expecting more of yourself.
- wilg 4y ago
  “Personally, I never create bugs.”
- whateveracct 4y ago
  Also they literally say in the postmortem that the same bug was resulted in exceptions most of the time and only sometimes leaked data. So all those exceptions were right there as a giant clue.

Bugs in your code are bugs in your code. If they are user-facing, you could've had tests to catch them.

sharemywin 4y ago

this.

curiousgal 4y ago

But it's an open-source library... /s

moffkalast 4y ago
Maybe they should be reminded that redis-py is under the MIT license. > THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

nawgz 4y ago

"Why didn't you simply have a test for an unexpected failure case which arose as a result of moving pieces across a distributed system?" - whateveracct

aldarisbm 4y ago
you’re retrieving data from a cache, is it so outrageous to say that they should confirm that the data belongs to the account is retrieving it?
- Atheros 4y ago
  It is pretty outrageous, yes. If Alice logs in and I correctly request Alice's details from the database, it's reasonable for me to expect that the database either returns Alice's details or an error. It shouldn't be up to application-layer programmers to code checks to make sure that a database doesn't return the wrong data 1% of the time. That kind of test is a test for the developers of Asyncio and Redis to implement, not users of Asyncio and Redis.
whateveracct 4y ago
I mean I have tested such things many times over the years. I'm no stranger to Redis cache bugs. Being a professional means expecting more of yourself.
wilg 4y ago
“Personally, I never create bugs.”
whateveracct 4y ago
Also they literally say in the postmortem that the same bug was resulted in exceptions most of the time and only sometimes leaked data. So all those exceptions were right there as a giant clue.