3 ms·
Sure I can imagine that. And in doing so, I imagine this attack is pretty unlikely. I mean, think of the confluence of things that have to line up for this to
by kelnos 4y ago
Sure I can imagine that. And in doing so, I imagine this attack is pretty unlikely.
I mean, think of the confluence of things that have to line up for this to work for someone. Many stars have to align in order for someone to successfully exploit this leak. Is it impossible? No, of course not, and so GH was right to rotate the key here, even if their server request logs suggested that no one had accessed it.
If people actually have this sort of attack in their threat model, there are ways to protect against it. Signing commits and verifying them. Pinning to a particular git SHA1 hash. Etc. If people are not doing these things, then it's possible they've made the decision not to worry about this sort of attack. Sure, you can disagree with, but I think you'd probably be in the minority. That's ok, though; you can certainly protect the things you're responsible for in stronger ways.
- lrvick 4y agoI have seen attacks along the lines I just outlined and well beyond in my industry many times. A wildcard TLS cert or an SSH host key in plaintext is a loaded weapon laying around and it will be used on a high value target. Sad fact is most of the companies that hold billions of dollars of customer assets do development exactly the same way a gaming company might. Those that even attempt security are unicorns. They bank everything on things like DNS, BGP, TLS certs, and ssh host keys working. This is like the medical industry before they learned hand washing was a thing. I teach every one of my clients how to do things like commit signing, but for every one I help improve there are 100 more on track to be hacked any day now. I can totally forgive a startup that cannot afford senior security engineers for a mistake like this, but Microsoft can afford that, or at least consultants, and yet they can not even enable optional signing for NPM, properly enforce git commit signing, or even protect an ssh host key trusted by millions in a TEE or HSM.