4 ms·
Pull requests are there for documentation, for automated quality checks and builds and deploys, for learning opportunities, and for getting other people to revi
by ThorsBane 4y ago
Pull requests are there for documentation, for automated quality checks and builds and deploys, for learning opportunities, and for getting other people to review it in case you missed something. This last piece may not always be the most effective. It's hard to incentivize sometimes when everyone is busy. But there are still valuable reasons to have a PR.
You can speed up the code review process by trusting people more on the basis of a longer tenure of high quality code and few bugs making it to production. Especially if they add screen shots or video snippets to the pull request to demonstrate the feature and to demonstrate edge cases.
Make it as asynchronous as possible and it scales to hardcore software engineering speed. And with time reduce the number of gatekeepers by assigning more authoritative titles with lower required numbers of approvals for things. That way we begin to promote the people who are demonstrating the most efficacy in shipping working code that gets the job done, rather than those people who are maxed out on talking a lot but don't ship any code at all. Or worse, the silent coasters who do nothing and say nothing lol. We see you now.
- lelanthran 4y ago> That way we begin to promote the people who are demonstrating the most efficacy in shipping working code that gets the job done, rather than those people who are maxed out on talking a lot but don't ship any code at all. Or worse, the silent coasters who do nothing and say nothing lol. We see you now I don't understand the glee that software developers feel when they get to police their peers performance. I honestly never see this in any other type of professionals. There's lots of other things that other professionals don't do that we promote, like micromanagement. Given the joy you are expressing over being able to police others performance, I get why code reviews can sometimes be so despised: when you have people taking joy in pointing out others performance, like you appear to do, the code review is just another tool of passive aggressive bullies.
- ThorsBane 4y ago[dead]