3 ms·
Saving a cropped image as an original with an edit list strikes me as a completely obvious and normal thing to do. It's an affordance that allows the user to go
by jeffbee 4y ago
Saving a cropped image as an original with an edit list strikes me as a completely obvious and normal thing to do. It's an affordance that allows the user to go back and un-crop things. If you undertook a field survey you would find users who were glad for this feature and I imagine zero users who had been harmed by it.
I don't understand all the brouhaha.
- pavon 4y agoThat isn't what is happening in either the original bug for the Google Pixel Markup tool or this bug in the Windows Snipping Tool. What is happening is that the software is overwriting the original image with the new one, but not truncating the file, so if the new compressed image data is smaller than the old, the remainder of the old image still exists at the end of the file. This data is not made available to the user to uncrop the data at a later time, so it provides no benefit to the user, just risk of privacy violations.
- creatonez 4y agoThis is not an undo feature. And if it were, it wouldn't be what an end user expects out of a .png file, but rather a .psd or .xcf file.
- devnullbrain 4y ago>and I imagine zero users who had been harmed by it. Because it's a zero day! You can't imagine someone cropping out banking information, identifying information in anonymous contexts, confidential information?
- olliej 4y ago> I don't understand all the brouhaha. Which you should take as a "maybe I have misunderstood the issue". This is not an edit list, or the ability to undo operations. The problem is you have an existing file ("foo.png" or whatever): oooooooooo then you make a new file with this data in memory: nnnnn This could be something like you opened the original foo.png file and made a change that results in the file shrinking, or it could be some completely unrelated data. Now you save this as foo.png and the editing program assumes opening a file for writing will erase the old data and writes out the new data. The end result is you have this file: nnnnnooooo e.g. the tail of the old file is still present in the file data. It turns out it's possible to recover the pixel data from those tail bytes, in spite of losing the compression state. Now the assumption that writing over an existing file will truncate/erase the original file is reasonable. That's the default behavior of most file IO APIs. I don't know what the windows app is doing, but the original android bug was an API that takes a mode string copied from posix's fopen, in which "w" means "open for writing, and erase any existing file", but then later on made an undocumented change that made opening a file with "w" no longer erase existing files.
- saagarjha 4y agoThank you for describing the sounds I made when I first heard this vulnerability described to me.