4 ms·

The default install script asks if you want to install key bindings and adds that to your bashrc. How did you install fzf?

sickmartian 4y ago
Not parent but on pop-os, using sudo apt install zfz I got the same behavior, had to add it myself to .bashrc
- acka 4y ago
  Pretty much par for the course, Linux distributions don't do per user configuration of tools beyond appending to PATH or setting some essential environment variables using scripts in in /etc/profile.d/. They will most certainly not mess with login scripts.
  - sophacles 4y ago
    Yeah sure, that makes sense. I'm surprised that the .deb doesn't install the stuff from `$upstream/shell` into `/usr/share/fzf` though. That's the sort of thing `/usr/share/$prog` is intended for. Then it would just be (in bash anyway): source /usr/share/fzf/keybindings.bash
    - farnerup 4y ago
      In debian: source /usr/share/doc/fzf/examples/completion.bash source /usr/share/doc/fzf/examples/key-bindings.bash
Steltek 4y ago
apt install? There's no way I'm integrating a core tool like that with a crude "curl | zsh" hack. How and when would it get updated? Am I expected to stick that in an Ansible playbook?
- tough 4y ago
  https://github.com/gantsign/ansible-role-oh-my-zsh https://github.com/gantsign/ansible-role-oh-my-zsh https://github.com/dotstrap/ansible-fzf https://github.com/dotstrap/ansible-fzf I don't see why not
- stevenhuang 4y ago
  Yes. It's a shell hook, it's expected for you to add it to your bash/zsh .rc yourself. How else can it work?
  - Steltek 4y ago
    For an article titled "You've installed fzf. Now what?", I would've expected step 1 to be "how to add the shell hook for your particular shell". Especially since people here are referencing extra integrations that the bundled shell hook doesn't setup.
  - 5e92cb50239222b 4y ago
    Packages can place init scripts into /etc/profile.d and those get autoloaded by shells.
    - ak217 4y ago
      This is what happens when tooling providers try to do their own packaging. Homebrew, apt, rpm, and other package managers, as well as bash, zsh and other shells, all offer standardized ways to install configuration loader scripts for the user's environment, and to display installer messages that prompt the user to do it - but fzf has a bunch of functionality to go around all that and auto-update itself in place and hack lines into the user's bashrc/zshrc. Not trying to single out fzf here - there are many other tools that do this - but I find this behavior really sad because it makes me very disinclined to trust the tool with anything. A command-line tool should not be trying to auto-update itself or manipulate dotfiles in the user's home directory. It's dangerous and unexpected.
      - ratorx 4y ago

sickmartian 4y ago

Not parent but on pop-os, using sudo apt install zfz I got the same behavior, had to add it myself to .bashrc

acka 4y ago
Pretty much par for the course, Linux distributions don't do per user configuration of tools beyond appending to PATH or setting some essential environment variables using scripts in in /etc/profile.d/. They will most certainly not mess with login scripts.
- sophacles 4y ago
  Yeah sure, that makes sense. I'm surprised that the .deb doesn't install the stuff from `$upstream/shell` into `/usr/share/fzf` though. That's the sort of thing `/usr/share/$prog` is intended for. Then it would just be (in bash anyway): source /usr/share/fzf/keybindings.bash
  - farnerup 4y ago
    In debian: source /usr/share/doc/fzf/examples/completion.bash source /usr/share/doc/fzf/examples/key-bindings.bash

Steltek 4y ago

apt install? There's no way I'm integrating a core tool like that with a crude "curl | zsh" hack. How and when would it get updated? Am I expected to stick that in an Ansible playbook?

tough 4y ago
https://github.com/gantsign/ansible-role-oh-my-zsh https://github.com/gantsign/ansible-role-oh-my-zsh https://github.com/dotstrap/ansible-fzf https://github.com/dotstrap/ansible-fzf I don't see why not
stevenhuang 4y ago
Yes. It's a shell hook, it's expected for you to add it to your bash/zsh .rc yourself. How else can it work?
- Steltek 4y ago
  For an article titled "You've installed fzf. Now what?", I would've expected step 1 to be "how to add the shell hook for your particular shell". Especially since people here are referencing extra integrations that the bundled shell hook doesn't setup.
- 5e92cb50239222b 4y ago
  Packages can place init scripts into /etc/profile.d and those get autoloaded by shells.
  - ak217 4y ago
    This is what happens when tooling providers try to do their own packaging. Homebrew, apt, rpm, and other package managers, as well as bash, zsh and other shells, all offer standardized ways to install configuration loader scripts for the user's environment, and to display installer messages that prompt the user to do it - but fzf has a bunch of functionality to go around all that and auto-update itself in place and hack lines into the user's bashrc/zshrc. Not trying to single out fzf here - there are many other tools that do this - but I find this behavior really sad because it makes me very disinclined to trust the tool with anything. A command-line tool should not be trying to auto-update itself or manipulate dotfiles in the user's home directory. It's dangerous and unexpected.
    - ratorx 4y ago