6 ms·
Don’t 100% agree with this, but it reminds me of a former coworker who got annoyed by all the “noise” of warnings (in a C++ codebase) so he set the flag warn=of
by sgerenser 4y ago
Don’t 100% agree with this, but it reminds me of a former coworker who got annoyed by all the “noise” of warnings (in a C++ codebase) so he set the flag warn=off. When I turned them back on, there were over 3000 warnings. Including one about a format string error that literally said “format string does not match arguments, this code will crash if executed.”
- Gigachad 4y agoWarnings should be checked by CI. Adding a new warning should fail the build requiring you to either deal with it, or add a disable comment to the section. Otherwise warnings are useless.
- rcyeh 4y agoWow! I was about to comment: when there are so many unheeded “noise” warnings, it can be easy to miss rare ones and new ones. I remember a codebase with thousands of warnings, and hiding among them were a few with the word “intend”, like: “if (condition); statement;” https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4390 https://learn.microsoft.com/en-us/cpp/error-messages/compile... “variable == value;” https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4553 https://learn.microsoft.com/en-us/cpp/error-messages/compile...