2 ms·
Right thinking people can also disagree on what is a false-positive. I remember a dialog between two people about one such thing. The summary is: 1. No impro
by aidenn0 4y ago
Right thinking people can also disagree on what is a false-positive. I remember a dialog between two people about one such thing. The summary is:
1. No improper behavior occurs currently because of the item flagged
2. However, reasonable changes to other parts of the code could cause the problem to occur
3. There is an obvious way of rewriting that avoids #2.
One person argued it was a false positive because of #1, while the other argued it was a true positive because #2 and #3 combined means you definitely want to change the code...
- Gigachad 4y agoOur general rule is that if you think the linter/warnings/style preference is wrong, open a PR up with the upstream linter project and convince them they should remove it. Otherwise just change the submission to pass.