3 ms·
I don't see it as a nitpick. The review can be valuable to people working on the code and users wondering how competent the Nord team is.
by ashwagary 4y ago
I don't see it as a nitpick. The review can be valuable to people working on the code and users wondering how competent the Nord team is.
- weird-eye-issue 4y agoOh come on. Review? Give me a break. Yeah this review will really give potential Nord users something to really think about before they purchase!
- noncoml 4y agoI hate this kind of “reviews” at work. 0 contribution to the actual functionality of the code, but strong opinions about superficial matters. The OP clearly just skimmed through the code without any interest in understanding how it actually works. Just a code bashing. Sad
- t8sr 4y agoYeah, I said I just read through it at random. I know that some programmers hate getting their code reviewed. All I can say is that code reviews are, in my experience, strongly correlated with code that's cheaper to maintain and operationally less surprising. Seeing this code certainly makes me think that the team writing it either doesn't have a culture of taking code reviews seriously, or that they don't have a lot of people who know the best practices in this language (Go). Either way, if they're not catching the easy stuff, I don't trust them to catch the subtle stuff either.