3 ms·

Those numbers don't support your statement

kasperni 4y ago
Could you tell me exactly what is the issue? sumNullsValhalla and sumOptionalValhalla returns 584,967 us/op and 572,833 us/op respectively sumSimpleValhalla and sumOptionalLongValhalla returns 327,927 us/op and 326,949 us/op respectively
- deleted 4y ago
  [deleted]
- rkuska 4y ago
  Maybe the person missed the difference because how your numbers are formatted: - OptionBenchmark.sumOptional avgt 5 2223,887 us/op vs - OptionBenchmark.sumOptionalValhalla avgt 5 572,833 us/op At least to me after the first read it seemed like comparison of two similair 5kish values.
  - karmakaze 4y ago
    I was also confused by 2223,887 us/op Is there a missing comma or is comma being used here as a decimal point?
    - zamnos 4y ago
      Comma is a decimal point, as used in many countries that aren't the United States.
      - karmakaze 4y ago
        Thanks. It would have been clearer to have omitted the decimals.
  - kasperni 4y ago
    Right, it is the output from JMH (Java Microbenchmark Harness) which includes the number of non-warmup-runs before the actual score. The original article included them as well so thought I would just post the numbers in the same format here.
- stonemetal12 4y ago
  sumOptionalLong 1,201,987 us/op | 326,949 us/op Sum Optional long is about 4x faster. 1.2Million microseconds per operation (pre Valhalla) vs 300K microseconds per operation (post Valhalla).
Manjuuu 4y ago
The important numbers are those related to Optional/OptionalLog, there is a 4x+ improvement after Valhalla.
misja111 4y ago
I was confused at first too, but there's a '5' after each benchmark which doesn't belong to the benchmark speed but which belongs to the benchmark title (?).
- kasperni 4y ago
  It it the number of non-warmup-runs for the benchmarking tool (JMH). The original article included them as well so thought I would just post the numbers in the same format here. But I totally understand that they are confusing if you are not in the Java ecosystem.

Could you tell me exactly what is the issue? sumNullsValhalla and sumOptionalValhalla returns 584,967 us/op and 572,833 us/op respectively sumSimpleValhalla and sumOptionalLongValhalla returns 327,927 us/op and 326,949 us/op respectively

deleted 4y ago
[deleted]
rkuska 4y ago
Maybe the person missed the difference because how your numbers are formatted: - OptionBenchmark.sumOptional avgt 5 2223,887 us/op vs - OptionBenchmark.sumOptionalValhalla avgt 5 572,833 us/op At least to me after the first read it seemed like comparison of two similair 5kish values.
- karmakaze 4y ago
  I was also confused by 2223,887 us/op Is there a missing comma or is comma being used here as a decimal point?
  - zamnos 4y ago
    Comma is a decimal point, as used in many countries that aren't the United States.
    - karmakaze 4y ago
      Thanks. It would have been clearer to have omitted the decimals.
- kasperni 4y ago
  Right, it is the output from JMH (Java Microbenchmark Harness) which includes the number of non-warmup-runs before the actual score. The original article included them as well so thought I would just post the numbers in the same format here.
stonemetal12 4y ago
sumOptionalLong 1,201,987 us/op | 326,949 us/op Sum Optional long is about 4x faster. 1.2Million microseconds per operation (pre Valhalla) vs 300K microseconds per operation (post Valhalla).

Manjuuu 4y ago

The important numbers are those related to Optional/OptionalLog, there is a 4x+ improvement after Valhalla.

misja111 4y ago

I was confused at first too, but there's a '5' after each benchmark which doesn't belong to the benchmark speed but which belongs to the benchmark title (?).

kasperni 4y ago
It it the number of non-warmup-runs for the benchmarking tool (JMH). The original article included them as well so thought I would just post the numbers in the same format here. But I totally understand that they are confusing if you are not in the Java ecosystem.