3 ms·
I'm guessing these two commits (one or both) are related to the CVEs: - https://github.com/home-assistant/supervisor/commit/2ae2d0e1070067b2b47bdfecfb44eca697b
by capableweb 4y ago
I'm guessing these two commits (one or both) are related to the CVEs:
- https://github.com/home-assistant/supervisor/commit/2ae2d0e1070067b2b47bdfecfb44eca697b964fd https://github.com/home-assistant/supervisor/commit/2ae2d0e1... ("Performance tweaks middleware" but doesn't seem to be about performance but about auth)
- https://github.com/home-assistant/supervisor/commit/3d74e07c5e977468611e26a64ad7926a5240e21b https://github.com/home-assistant/supervisor/commit/3d74e07c... ("Backport core api filter" but doing request filtering based on "potential harmful query string")
No need to be secretive about it. Updates have been automatically pushed + if someone wanted to see how it was fixed in order to exploit it, they'll be able to browse through the commits just like I did, and probably find it even easier as I'm no pentester, just a casual programmer.
- function_seven 4y agoThank you! This is exactly what I was looking for. That second link seems pretty obvious.
- josephcsible 4y agohttps://github.com/home-assistant/supervisor/commit/3d74e07c5e977468611e26a64ad7926a5240e21b#diff-b87a8d41af603d8f42fbd98aba995716a072ae19d0201db5d91388f53463f7a6R116-R135 https://github.com/home-assistant/supervisor/commit/3d74e07c... Oh dear. This is awful for the same reason that https://thedailywtf.com/articles/Injection_Rejection https://thedailywtf.com/articles/Injection_Rejection is.
- ratorx 4y agoHaven’t read all the code, but If it’s defense in depth, then it seems fine. If it’s the sole protection towards SQL injections, then it seems quite sketchy.