3 ms·

I think they are saying the app could be a pre-commit hook where their API is hit before code goes up to remote

• eikenberry 4y ago
  Yes. I'm saying that due to this relying on an external service it would be inappropriate for a pre-commit hook as you could only commit while online.
  • habitue 4y ago
    pre-push hook?
  • verdverm 4y ago
    git commit --no-verify ?
    • bottled_poe 4y ago
      If the developer wants to slow their own development workflow by delaying the code review, that’s.. concerning.
      • verdverm 4y ago
        in what way is your comment pertaining to this thread? If a user is offline, they are not going to be able to push code for review anyway. Either way, it seems prudent to shift validation and checks closer to the developer, before pushing code. Otherwise you end up with a series of commit & push, wait for check, commit & push fixes, wait for check, commit & push more fixes...
  • lwhi 4y ago
    > [...] it would be inappropriate for a pre-commit hook as you could only commit while online. Why does that matter?
    • eurasiantiger 4y ago
      Hey, some of us live in caves.
      • eloff 4y ago
        Add the —no-verify flag when working out of your cave.