4 ms·

Neat little project. Easy to setup and use. Unfortunately with macOS's "Dark Mode" enabled the colors have little or no contrast. And the UI renders very small

Neat little project. Easy to setup and use. Unfortunately with macOS's "Dark Mode" enabled the colors have little or no contrast. And the UI renders very small for my eyes (and compared to the demo gif). This is a criticism of Qt (or maybe its python bindings) rather than this project. (Screenshot: https://imgur.com/a/G9eAPoO https://imgur.com/a/G9eAPoO) I wonder if there's a way to shimmy in a "modern macOS Qt renderer" or something into an existing project like this without a rewrite?

fellerts 4y ago
Thanks for checking it out. You could play with the QT_SCALE_FACTOR environment variable to fix the scaling issue at least. Something like this could work: $ QT_SCALE_FACTOR=2 python procal.py As for the colors, that's probably something this tool should handle. I'll take a look to see if this is an easy fix.
fellerts 4y ago
> I wonder if there's a way to shimmy in a "modern macOS Qt renderer" or something into an existing project like this without a rewrite? Apparently there is. I hacked something together in a new branch: https://github.com/fellerts/procal/tree/fredrik/theme https://github.com/fellerts/procal/tree/fredrik/theme. Feel free to check it out and let me know how it works for you.
- eql5 4y ago
  I tried on macOS, yes dark mode works great now, thanks. But I needed to change all QFont('monospace', 10) occurrences to QFont('Monaco', 12) in order to make it look nice.
  - fellerts 4y ago
    Thanks for trying it out. If you wouldn't mind, I'd appreciate it if you could open an issue with a screenshot of how the default behavior looked. Edit: merged a fix for this, thanks for reporting.
  - pxc 4y ago
    Shouldn't it be your operating system's job (or yours) to make the monospace font alias on your system point to a nice font?
    - eql5 4y ago
      In a perfect world, yes! But in my experience with Qt, you always have to adjust font names separately for every OS. This is especially true for nice coding fonts. If I had written that program, I would have brought my own font (like "Hack"), and simply set the pixel size of the font, to ensure it's exactly the same size on any OS (and I would have written it in QML, with heavy usage of Repeater, which would simplify the UI code a lot, but I digress...).

fellerts 4y ago

Thanks for checking it out. You could play with the QT_SCALE_FACTOR environment variable to fix the scaling issue at least. Something like this could work: $ QT_SCALE_FACTOR=2 python procal.py As for the colors, that's probably something this tool should handle. I'll take a look to see if this is an easy fix.

fellerts 4y ago

> I wonder if there's a way to shimmy in a "modern macOS Qt renderer" or something into an existing project like this without a rewrite? Apparently there is. I hacked something together in a new branch: https://github.com/fellerts/procal/tree/fredrik/theme https://github.com/fellerts/procal/tree/fredrik/theme. Feel free to check it out and let me know how it works for you.

eql5 4y ago
I tried on macOS, yes dark mode works great now, thanks. But I needed to change all QFont('monospace', 10) occurrences to QFont('Monaco', 12) in order to make it look nice.
- fellerts 4y ago
  Thanks for trying it out. If you wouldn't mind, I'd appreciate it if you could open an issue with a screenshot of how the default behavior looked. Edit: merged a fix for this, thanks for reporting.
- pxc 4y ago
  Shouldn't it be your operating system's job (or yours) to make the monospace font alias on your system point to a nice font?
  - eql5 4y ago
    In a perfect world, yes! But in my experience with Qt, you always have to adjust font names separately for every OS. This is especially true for nice coding fonts. If I had written that program, I would have brought my own font (like "Hack"), and simply set the pixel size of the font, to ensure it's exactly the same size on any OS (and I would have written it in QML, with heavy usage of Repeater, which would simplify the UI code a lot, but I digress...).