4 ms·

I can't work out what is actually wrong here - there appears to be very little detail, would you mind explaining?

• Scarbutt 4y ago
  False warning about unused definition 'salary' when it is actually being used.
  • Jenk 4y ago
    Thank you for explaining - I didn't think to click on the thumbnail as I thought the snippet _is_ the expanded thumbnail. The way I see/read it: it _isn't_ being used in respect to nothing _reads_ it, except within the calculation to raise - there's nothing that reads the result of the raise. It's warning you that you are (potentially) needlessly capturing state. I agree it's a valid warning (for that specific example.) I appreciate it is just an example to demonstrate the issue but I am unable to deduce a scenario where that wouldn't be a valid warning.
    • jsyolo 4y ago
      'salary' is part of the constructor's body and the constructor is being used, it shouldn't warn. Look how it just warns about 'salary' but not about 'name', in the image, only 'salary' is gray out. It's not even consistent.