3 ms·
I use Github Desktop. One thing I do like a lot is that the diff I see is exactly what my code reviewers will see. Personally, I spend a lot of time reviewing
by ripplefringe 4y ago
I use Github Desktop. One thing I do like a lot is that the diff I see is exactly what my code reviewers will see.
Personally, I spend a lot of time reviewing other's code ad also going through my own PR's in Github. I'm very familiar with that view. I think it helps my brain that I use the same diff view when I'm working locally and when I'm reviewing code on Github.
- u801e 4y ago>> So basically, now we can do `git diff master` in a GUI. > One thing I do like a lot is that the diff I see is exactly what my code reviewers will see. What will they see in the diff that you can see using Github Desktop that you wouldn't see by running git diff master?
- ripplefringe 4y agoColors and fonts especially. After ten years my brain is fast at reading a GitHub diff. It’s pretty slow at reading a terminal diff because I don’t do it very much.
- u801e 4y agoPresumably most people use an editor or IDE for coding and it's likely that editor or IDE could also be used to display diffs, so I don't really see colors or fonts being an issue. The IDE or editor could also be configured to use colors and fonts similar to what's used in Github. For example, vim has a colorscheme[1] that's similar to what Github offers. [1] https://github.com/cormacrelf/vim-colors-github https://github.com/cormacrelf/vim-colors-github