Probably many have written a vector header like this. It baffles me why this one reaches the front page of HN given that the implementation is not that great. A

Probably many have written a vector header like this. It baffles me why this one reaches the front page of HN given that the implementation is not that great. A few problems (some have been mentioned by others as well). 1. not using "do {} while (0)". This may lead to compile errors. 2. using uint32_t for capacity. On 64-bit machine, this doesn't save memory. 3. DYN_ARR_RESIZE() may have a quadratic time complexity if some is calling DYN_ARR_RESIZE(a, 10); DYN_ARR_RESIZE(a, 11); DYN_ARR_RESIZE(a, 12) etc in a loop. kv_resize() in kvec.h wouldn't have this problem. 4. Segfault if capacity is 0.