3 ms·
Is there a channel where we can share suggestions for the upgrade guide? I think it would save people some time if the phx 1.6 -> phx 1.7 upgrade instructions
by AlchemistCamp 4y ago
Is there a channel where we can share suggestions for the upgrade guide?
I think it would save people some time if the phx 1.6 -> phx 1.7 upgrade instructions started with the following two steps:
1.) Upgrade LiveView to 0.18.x (with link to https://hexdocs.pm/phoenix_live_view/changelog.html#0-18-0-2022-09-20 https://hexdocs.pm/phoenix_live_view/changelog.html#0-18-0-2...)
2.) Update web.ex macros for Phoenix Component (with link to https://hexdocs.pm/phoenix_view/Phoenix.View.html#module-replaced-by-phoenix-component https://hexdocs.pm/phoenix_view/Phoenix.View.html#module-rep...)
Then the upgrade doc will work and people won’t get stuck trying to follow those instructions with a Phoenix 1.6 app using whatever version of LiveView they had before.
- josevalim 4y agoPlease open up an issue.
- AlchemistCamp 4y agoOkay! Will do.
- nickjj 4y agoI updated my example Docker / Phoenix app from 1.6 to 1.7 this morning. I put it all into 1 commit: https://github.com/nickjj/docker-phoenix-example/commit/3733fc2f263191eeb7a9b36dce635a82c848ef7e https://github.com/nickjj/docker-phoenix-example/commit/3733... There were a number of things not covered in the upgrade guide. Lots of small changes between what the new app generator provides, csrf tokens being set in a different way, etc..