3 ms·
Too many macros and macros with hidden parameters make the code difficult to follow and should be avoided if possible, IMHO. For instance, here function void u
by mytailorisrich 4y ago
Too many macros and macros with hidden parameters make the code difficult to follow and should be avoided if possible, IMHO.
For instance, here function void user_tasks_html(FILE fp, user_tasks data) requires fp as argument but then fp does not show up at all in the whole function.
So one might think this is a leftover that should be removed altogether. Or they might indeed conclude that there is macro shenanigans going on and start looking up the definition of each macro to understand what is really going on.
If those macros do help then at least there should be a comment at the beginning of the function to state clearly that all the following macros write into fp.