5 ms·
We've had code review dueling for the past few years, and it has really helped with the quality of code and pull requests. In the past, programmers submitted a
by IncRnd 4y ago
We've had code review dueling for the past few years, and it has really helped with the quality of code and pull requests.
In the past, programmers submitted all sorts of junk code into our version control, what I would today call chatgpt nonsense. At the time it was likely Stack Overflow nonsense. In any case, Code Review Dueling has changed the landscape of our coding. For the past two years, not a single negative comment has appeared on code pull requests. All it took was the deaths of a few unqualified people who lied on their resumes.
This "old is new" methodology has caused programmers and architects to work with other people before ever writing code or designing systems. In our monthly metrics report from the CI (but not CD) pipeline, I also noticed that we no longer import any dependencies from 3rd parties. In fact, IT has shutdown all access to pip, apt-get, and so forth. Everything is custom and has been beautifully designed and coded in-house.
It's absolutely amazing. Even our customers regularly request they be allowed to purchase extra copies of our software, just to give to their children and grandchildren, when they come of age. But before purchasing extra copies, they always call first, since our license lawyers are very prolific, proactive, and protective of our rights.
- siva7 4y agoThis has to be satire. Please tell me it is
- throwawaylinux 4y agoWhat is "code review dueling", can you explain this a bit more?
- rippercushions 4y agoSimple: if you call into question another coder's syntax, logic or variable naming conventions, you must be prepared to defend your stance until death. En garde!
- IncRnd 4y agoWe want programmers with honor, so anytime there is a review the submitter can challenge the reviewer to a duel to erase their incorrect comments. Also the reviewer can challenge the submitter to a duel, when they think the code quality is too low to check into the code base.
- throwawaylinux 4y agoSo what does a duel involve?
- deleted 4y ago[deleted]
- pc86 4y agoThe above post is clearly a joke.
- misja111 4y agoI can't answer for OP, but in my company we settle disagreements over code reviews by fist fights.
- komali2 4y agoI continue to settle most scores in my life with matches of super smash bros: melee. Most phones can handle dolphin gamecube emulation nowadays. As long as it can be plugged into an HDMI display somehow (Samsung Dex or whatever), and you have Bluetooth controllers on hand (weird, I always do), you can set up a modern duel in about ten minutes.
- IncRnd 4y ago
- rendall 4y ago"My code review dueling post has people asking a lot of questions already answered by my post."
- stackbutterflow 4y agoI never thought I'd see the birth of a copy pasta on HN.
- SQueeeeeL 4y agoWe're unfortunately probably beyond the point of any new copypastas being created. Most of those were created on the "old Internet", where things were pretty small, chaotic, and decentralized. Nowadays, all engagement is primarily reaction driven, so the only things that typically take off are references to other cultural touchstones
- deleted 4y ago[deleted]
- deleted 4y ago[deleted]