4 ms·

I wanted to say thank you for picking a business friendly license! Watch out for the (presumably old) GitHub organization in .gitmodules: https://github.com/hi

I wanted to say thank you for picking a business friendly license! Watch out for the (presumably old) GitHub organization in .gitmodules: https://github.com/highlight/highlight/blob/d818969acddd7c741d511f561edfde840927c92e/.gitmodules#L3 https://github.com/highlight/highlight/blob/d818969acddd7c74... OT1H, GH does a 301 to the new name, but OTOH unknown how long that lasts and is one more thing to go off the rails for fresh clones. It has been my experience that using the https URL makes clones easier for users which may not have set up ssh auth, but it depends on the target audience and whether you have some internal tooling that depends on that submodule coming down over ssh

vadman97 4y ago
That's a great point! Just opened a PR to fix this: https://github.com/highlight/highlight/pull/4362 https://github.com/highlight/highlight/pull/4362 Switching this to https too since the our rrweb fork is now public (ssh reference was previously necessary for cloning a private fork).
nerdyadventurer 4y ago
> I wanted to say thank you for picking a business friendly license! Is not AGPL business friendly, if not why? Only restriction that I know is you cannot provide it as a service. Databases like ScyllaDB are AGPL and they are doing fine.