3 ms·
I mostly don't like how removing a parameter to a function can make it become 1 line, and then in the diff I have no idea of what has happened. In reviews I al
by LtWorf 4y ago
I mostly don't like how removing a parameter to a function can make it become 1 line, and then in the diff I have no idea of what has happened.
In reviews I always ask that there must be a separate formatting commit, at the end.
Also, because our builds fail if the code is not formatted, that means constant reformatting and moving around of commits.
In the end the time wasted to start the container to run black (if you use the distribution one, every version formats differently), to run black (which is terribly slow), and juggle the commits around is hardly worth it.
However I believe from a management perspective it gets rid of discussions about style in the reviews, so it looks like time is being saved because now the developers waste it each on their own in silence, without communicating.
- ttyprintk 4y agoAll your points are right in what I’d say is the most common ambient professional environment. We had an internal debate about how to gauge code quality. One camp only allowed the combination of black format plus coverage. To play devils advocate, I said that the number of asserts removed or added per merge request.