Putting string data in a vector<char> for starters is a big code smell. If you do, you're not using the language and the standard library the way they are suppo

Putting string data in a vector<char> for starters is a big code smell. If you do, you're not using the language and the standard library the way they are supposed to be used and it's on you to make sure you do everything right. Then combining that with C-style string handling functions, without taking all the extra care, is just asking for trouble IMO.