3 ms·
> Today’s one is about how (not) to “teach” during code reviews. > It’s not bad to “teach” in code reviews, but it should happen on an eye-to-eye level. > But
by l0b0 4y ago
> Today’s one is about how (not) to “teach” during code reviews.
> It’s not bad to “teach” in code reviews, but it should happen on an eye-to-eye level.
> But first, let me show you how I’d phrase the feedback for this example:
> “I had a hard time grasping what the method does. What about changing the method name to openRequest() to make the methods objective clearer and improve code readability?”
So the headline is just wrong, it's about not being a dick or vague when writing code reviews.