2 ms·
Why care much about "style" if you already know intention clearly ? In worst case, the submitter will get "ignored" later with good advice and it's bad for him
by revskill 4y ago
Why care much about "style" if you already know intention clearly ?
In worst case, the submitter will get "ignored" later with good advice and it's bad for him and the team itself.
You don't need to pass code review to get merged. There's always a DoD for it.
What to do in this case ? Just answer it the way you feel good for the team. Don't care much about style.
In my case, i'm always grateful for being taught by teammates. I don't care much about "teaching" or anything like that. Intention is all you care.
- yuliyp 4y ago> Why care much about "style" if you already know intention clearly ? Because it may have taken me 5 minutes to understand what the function did because its name misled me, and that was with the benefit of the context of the PR. Trying to make sense of it while debugging something broken 6 months later is going to take even longer, and getting the naming right may pay significant dividends later on.