3 ms·
The code from OpenSSL in question is not bad, actually. Apart of purely stylistic issues, this code is: * robust, handles all error conditions, * more or les
by alexeiz 15y ago
The code from OpenSSL in question is not bad, actually. Apart of purely stylistic issues, this code is:
* robust, handles all error conditions,
* more or less well structured, I had no problems reading it, although I strongly prefer different coding style,
* is on par with the best examples of C code I have encountered,
* tricks like jumping into if(0) block are common for error handling in C. Once you get used to it, it reads naturally.
So get over it, people. Just because some code doesn't look like what you'd write doesn't mean it's bad. Try to look beyond stylistic issues.