4 ms·
Big disagree on that. I think the commit message should tell me what the change does, not why.
by Kiro 4y ago
Big disagree on that. I think the commit message should tell me what the change does, not why.
- jkukul 4y agoIt's a bit ironic. You just stated your opinion without explaining why you think that way.
- deleted 4y ago[deleted]
- deleted 4y ago[deleted]
- silisili 4y agoIdeally, both. 'Change rounding to thousandths' isn't overly helpful, and probably apparent. 'Fix overspending bug' is vague. 'Fix overspending issue by rounding to thousandths instead of hundredths' is the ideal commit msg here, as it gives a brief what and why. Possibly even with a ticket number, though I see how after years and switching systems that becomes less useful. More useful is briefly describing the why as a code comment, using good judgement of course.
- yreg 4y agoDepends on the workflow. You can e.g. start every commit with a ticket number and explain the Why in the ticket.
- silisili 4y agoIn my experience this works super well UNTIL you inevitably switch ticketing systems and lose it all. Happened to all of our stuff twice now :(.
- yreg 4y agoI doubt switching ticketing systems is inevitable, but even then we would definitely migrate all the data to the new system. The spec is far too important.