2 ms·
One of the goals of a code review should be to establish shared ownership (or at least shared-semi-competence). But code reviews have at least one other way of
by AnimalMuppet 4y ago
One of the goals of a code review should be to establish shared ownership (or at least shared-semi-competence).
But code reviews have at least one other way of contributing value. They help find (moderately) obvious bugs, unsafe code, and unclear code. There is value in keeping blatant stupidity out of your codebase.
- dcow 4y agoThose are 2nd order benefits derived from establishing shared ownership.
- AnimalMuppet 4y agoThat statement is false. If I call your code, I don't have to share ownership of your code to benefit from your code not having a bug in it.
- dcow 4y agoThat’s not what I said. I said you get the second order benefits by establishing shared ownership. Of course the qualities of the code are conferred to callers… that’s obvious.