3 ms·

Code reviews are useful when the reviewers don't have OCD, which is only about half the time.

• Gigachad 4y ago
  All OCD and preferences should be encoded in the linter/formatter or a wiki page. It's obviously a waste of time to argue menial preferences in review.
  • hot_gril 4y ago
    Some of the documented preferences are annoying too, but at least you can adhere to them without going back and forth with a reviewer. What builds friendships is when you review each other's code in a way that ignores the parts of the style guide you both consider silly.
• AlbertCory 4y ago
  The xkcd cartoon hits on an orthogonal dimension, almost universally ignored, which is why I liked it: It's an economic endeavor, not an artistic one. I've been in some choruses, and it's really worth it to make every single thing as good as you can possibly make it. The audience for the concert appreciates the totality of what you do. A coding project is not art like that. It's not worth making most things perfect, and moreover, you can't tell now which ones are going to be worth it. Every hour you spend on polishing something that's going to be thrown away in two years is an hour you can't be doing something more valuable. The Net Present Value of extra work five years from now is almost zero.
  • hot_gril 4y ago
    Well it's the same dimension, obsessive code review wastes time and money.