3 ms·
I'm always willing to dogpile on DataDog (no pun intended), given bad experiences with their sales, but all I'm reading out of this is that the DD person didn't
by bdcravens 4y ago
I'm always willing to dogpile on DataDog (no pun intended), given bad experiences with their sales, but all I'm reading out of this is that the DD person didn't want to review it out of a potential conflict of interest. It was reviewed however by someone else. Am I missing something here?
- nabakin 4y agoYou're missing that this was a year-old PR ready to merge but it was stopped from merging by DataDog because it makes it easier for users to migrate from DataDog to another logging service
- bdcravens 4y agoNo, I am unsurprised by the DataDog taking that position; it fits with what I know of the company. However as someone pointed out, the comment in question wasn't originally linked, but I see it now.
- bushbaba 4y agoWhere did DD stop the merge. I just saw them simply state that the reviewer didn't want to review it as they work at Datadog. It could simply be that they are biased TO merge it even if it contains flaws. Having an independent reviewer ensures the code quality meets the bar.
- jru 4y agoThe OP didn't link directly to the comment and it's buried in the thread: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/5836#issuecomment-1404724926 https://github.com/open-telemetry/opentelemetry-collector-co...
- s17n 4y agohttps://github.com/open-telemetry/opentelemetry-collector-contrib/pull/5836#issuecomment-1404724926 https://github.com/open-telemetry/opentelemetry-collector-co...