4 ms·
Reviewer is a term of status for WebKit contributors[1]. > A potential Reviewer may be nominated once they have submitted a minimum of 80 good patches. […] A p
by eyelidlessness 4y ago
Reviewer is a term of status for WebKit contributors[1].
> A potential Reviewer may be nominated once they have submitted a minimum of 80 good patches. […] A person who submits many patches but does not show good collaboration skills, code understanding or understanding of project policies may never be nominated.
And when someone becomes a WebKit Reviewer, their status is announced publicly under a special tag[2]. My interpretation (I’m happy to be corrected if mistaken) is that this status is essentially maintainer, but perhaps outside the team at Apple.
1: https://webkit.org/commit-and-review-policy/#criteria-for-reviewers https://webkit.org/commit-and-review-policy/#criteria-for-re...
2: https://webkit.org/blog/tag/reviewers/ https://webkit.org/blog/tag/reviewers/
- capableweb 4y agoThat probably explains it! Thank you for explaining it.
- olliej 4y agoWebkit policy requires all reviewers be approved openly - it’s not possible for an Apple employee to land changes without a project approved reviewer. The reality is that the majority of webkit engineers and reviewers are employed by Apple, so an Apple engineer can always talk to a reviewer in person if they’re trying to get a faster turn around. Similarly Apple employees have to go through the same nomination process to become reviewers, and are subject to the same requirements.
- eyelidlessness 4y agoExcellent clarification thank you.