3 ms·
Well, I'm locked out of my github account right now and don't feel like going through all those hoops right now but I wanted to point something minor out. In t
by ethanwillis 4y ago
Well, I'm locked out of my github account right now and don't feel like going through all those hoops right now but I wanted to point something minor out.
In this line, https://github.com/approximatelabs/sketch/blob/9d567ec161015d54107aae5e10f242ab630759b3/sketch/sketches.py#L304 https://github.com/approximatelabs/sketch/blob/9d567ec161015...
I think you can end up marking control characters as "UNKNOWN" characters by accident by assuming that in all contexts/environments that dictionary.items() always returns items in a consistent order. This isn't always true.
edit: actually with the way the code is written if you have any overlapping ranges at all you'll end up double/triple/etc. counting a character into multiple categories.