4 ms·
> For my own PRs, I review them myself first This is another truly great pro-tip from this thread. It makes a world of difference seeing ones code outside of o
by sibeliuss 4y ago
> For my own PRs, I review them myself first
This is another truly great pro-tip from this thread. It makes a world of difference seeing ones code outside of ones editor and in a different interface, broken up by GitHub's UI. I often write comments to myself as I'm reviewing and then resolve my notes via future commits.
Towards the end stages of a lengthy PR I'll often rapidly self-review, push, _re_-self-review, push and then so on. All the way until its totally polished. This process has never done me wrong.
- karmakaze 4y agoYes, that's exactly how it goes. Similar to how right after meeting a deadline and the whole team breathes a sigh of relief. I worked one place that made golden masters for shrink-wrap reproduction. The brilliant person in shipping (as in "shipping and receiving" not specifically software) would secretly hold on to them for a week regardless of how behind schedule and late we were with the release. Almost every time a day or two later, someone would remember something and there would be a panic recall and Leslie would say "no problem" let me know when you have it.