3 ms·
I consider “code quality” in our codebase to largely be defined by “does it follow our opinionated architecture?” If the answer is “No”, it can be difficult fo
by monocularvision 4y ago
I consider “code quality” in our codebase to largely be defined by “does it follow our opinionated architecture?”
If the answer is “No”, it can be difficult for others to understand. Reworking that code to follow our architecture generally makes it easier for us all to follow.
One might need to not follow the architecture because it doesn’t handle something new to the app. When that happens, we try, first, to update the architecture to be able to handle the requirement and then implement the feature. But if that isn’t possible, we plan to clean up the debt as soon as we can after shipping.
Overall, it has worked remarkably well for our team and has led to what I consider the “cleanest” code base I have ever worked on. But it is dependent upon us having a shared understanding of how we implement features.
- moris_borris 4y agoThe miracle of a clean code base is that it means some programmers got together and agreed on a bunch of things.
- tatersolid 4y agoI’d think it’s the opposite: clean code indicates 1-2 opinionated individuals built it. Committee decisions are almost always overly complex compromises with too many special cases. See most RFCs, IEEE specs, congressional bills.