4 ms·
This is cool, but I'm curious to know what took 16k commits. The projects that I've been on with more then ten thousand commits had many dozens or hundreds of f
by bastawhiz 4y ago
This is cool, but I'm curious to know what took 16k commits. The projects that I've been on with more then ten thousand commits had many dozens or hundreds of folks working full time. And to crank that out in 1.5 years! That's 22 commits per day, every day. That's a fairly meaty engineering org's cadence. Is there some complexity that needed to be overcome that the post doesn't get into?
- hansonkd 4y agoA lot of one word typo fixes, commits to fix one blank line, and automated package rewrites. Each release is about 3-4 commits of the same thing (bumping versions, etc) with 1-4 releases a day. So to fix a one word typo ends up being about 3 separate commits.
- leoloso 4y agocheck my response above
- rmccue 4y agoFor comparison, the WordPress REST API was about 4k commits over ~4 years or so (prior to us merging it into WordPress itself): https://github.com/WP-API/WP-API https://github.com/WP-API/WP-API (That said, commit count is a pretty useless metric.)
- leoloso 4y agoThere was a lot of rewriting stuff to make the engine GraphQL-first. Before, the engine received a different spec as input, and GraphQL worked behind an adapter. Now, the engine speaks GraphQL language. Then completing the GraphQL schema, fully complying with the spec, and adding all the new features. That was quite a bit of effort. Yes, there were many "typo" commits, changing simply one word. But there were also plenty of commits with dozens of changes and, in the initial rewriting stage, even hundreds of changes. It really took 16k commits. I'll write a blog post on graphql-api.com and provide some more info (maybe sometime this weekend?).