15 ms·
If the squash has, say, < ~150 lines of code the edge case should A) jump out on the PR, B) be covered by tests. Meanwhile if you demand meaningful messages fo
by pydry 4y ago
If the squash has, say, < ~150 lines of code the edge case should A) jump out on the PR, B) be covered by tests.
Meanwhile if you demand meaningful messages for every tiny commit, you'll be lucky if you get much more than "fix".
- lucumo 4y agoAgain, humans are flawed. We have code that is probably broken. There's definitely a chance that the test is broken or incomplete too. Also, I demand nothing, not even a certain commit message. What I ask is that you don't expend effort to destroy information. I understand the desire to hide one's flaws. To hide the thought process to make yourself look better. But it's not necessary. Everybody has flaws and it's far better to have the thinking in the open, so we can see and work with it.