3 ms·
Yes. If I see some behaviour that changed in a commit that says "lint fixes", I can be pretty sure you didn't intend that. I'm still going to check, but if I d
by lucumo 4y ago
Yes.
If I see some behaviour that changed in a commit that says "lint fixes", I can be pretty sure you didn't intend that. I'm still going to check, but if I don't find anything to give me pause, I'm confident in reversing it.
If I see it in a commit that says "fix edge case", I'm going to check, double check and triple check if that edge case is still resolved after my fix.
The "oops" and "work in progress" things hold no information, but since that's the default, well... Too bad.
A cute little paragraph is almost certainly going to leave out details I need. I'll probably ignore it, because it's either unnecessary verbiage, or inane. Probably both.
- pydry 4y agoIf the squash has, say, < ~150 lines of code the edge case should A) jump out on the PR, B) be covered by tests. Meanwhile if you demand meaningful messages for every tiny commit, you'll be lucky if you get much more than "fix".
- lucumo 4y agoAgain, humans are flawed. We have code that is probably broken. There's definitely a chance that the test is broken or incomplete too. Also, I demand nothing, not even a certain commit message. What I ask is that you don't expend effort to destroy information. I understand the desire to hide one's flaws. To hide the thought process to make yourself look better. But it's not necessary. Everybody has flaws and it's far better to have the thinking in the open, so we can see and work with it.