3 ms·
If someone has a clean commit that is a district unit of functionally and passes all tests, why would that not have simply been committed as an independent chan
by jrmg 4y ago
If someone has a clean commit that is a district unit of functionally and passes all tests, why would that not have simply been committed as an independent change prior to continuing work?
This is exactly the kind of change I’m talking about - the problem is it’s later discovered to have flaws that the tests did not reveal, but enough time has passed that later changes depend on it.
I am not sure I have ever encountered a situation where targeting a single commit to revert would have actually worked(from a rebased merge).
It almost always worked in my experience. The systems we’ve worked on must be architected differently.
If something is worth reverting and was missed by the engineer and the reviewers, it seems the like fix should also atomically contain the explaination with a test to prove the issue was fixed.
Agreed - the problem comes if the fix is not obvious and a fix cannot immediately be applied. In our workflow, when we have belatedly learned of a problem a change is causing, a revert should then be done to keep the integrity of the main branch.
I should stress that this is an exceptional case - but we did see it a few times a year.