3 ms·
does code review need to be tied to your scm? i can see how it means slightly less work, but what's the minimum infrastructure you need to make it independent
by andrewcooke 15y ago
does code review need to be tied to your scm? i can see how it means slightly less work, but what's the minimum infrastructure you need to make it independent of the scm? i would guess it's little more than some bash and procmail scripts (assuming unix).
- obtu 15y agoThe kernel model (git format-patch, git send-email, git am --signoff) might be automated a little bit more with procmail scripts that auto-apply patches sent to a mailing list once they've been acked as needing no further revision. That workflow has the benefit of decentralisation, but I don't think other SCMs have the equivalent commands. Widespread support is particularly necessary for the people who initiate reviews, since they are more numerous and less likely to have specific tools installed.
- breckinloggins 15y agoIt doesn't have to be, but integrating with GitHub's line- and commit-level comments and pull requests certainly helps incorporate code reviews into the history of the project and each file in it.